Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use StatefulSet status instead of List Pod by selector labels #228

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

kobzonega
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

After changes from PR #172 controllers are waiting for recreating pods with new label ydb.tech/statefulset-name. WIth strategyUpdate: OnDelete policy usage it affect controllers by infinite loop for pods create by old generation of StatefulSet.

2024-07-01T09:58:40Z DEBUG events Waiting for number of running pods to match expected: 0 != 1 {"type": "Normal", "object": {"kind":"Database","namespace":"ydb-dev","name":"example-1","uid":"41243125-668b-4706-994d-6d5092f8df8f","apiVersion":"ydb.tech/v1alpha1","resourceVersion":"83370878"}, "reason": "Provisioning"}

What is the new behavior?

  • use StatefulSet status instead of List Pod by labels inside waitForStatefulSetToScale
  • fix missing ydb.tech/remote-cluster label in StatefulSet builder for Nodeset objects

Other information

@kobzonega kobzonega merged commit 7245f02 into master Jul 1, 2024
7 checks passed
@kobzonega kobzonega deleted the fix-pod-list-by-labels branch July 1, 2024 11:19
kobzonega added a commit to kobzonega/ydb-kubernetes-operator that referenced this pull request Jul 15, 2024
…atform#228)

* use statefulset status instead of list pod by labels

* fix missing "ydb.tech/remote-cluster" label

* bump helm chart version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants